Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking world limit 3: Network compatible with old clients/servers [WIP] #12142

Closed
wants to merge 37 commits into from

Conversation

proller
Copy link
Contributor

@proller proller commented Mar 19, 2022

Based on #11910

With USE_POS32=1 can connect to older servers or be server for older clients

NOT FINISHED, HAVE BUGS

@rubenwardy rubenwardy closed this Mar 19, 2022
@rubenwardy
Copy link
Member

rubenwardy commented Mar 19, 2022

Basing a PR on a PR on a PR is not ok, please also wait for confirmation or rejection about whether we want to go ahead on this

@servantoftestator
Copy link

servantoftestator commented Jul 13, 2022

Aside from the fact the core maintainers will never merge a PR increasing world size no matter how compatible or well done it is. How does the backwards compatibility affect performance of clients on this series of PR's on old servers/worlds for the 5.x.x series of minetest engine? If there is some terrible degredation in performance, then that should be fixed or discussed.

@rubenwardy
Copy link
Member

rubenwardy commented Jul 13, 2022

Aside from the fact the core maintainers will never merge a PR increasing world size no matter how compatible or well done it is.

This is incorrect. We've decided not to do it at this time as we want to prioritise other things, such as those outlined by the roadmap: Graphics, User Interfaces, Entities, and Maintenance. In the future once these things are improved, this feature may be reconsidered

I'm in favour of expanding the world size, but it needs to be weighed up against other things. Is a bigger world really more important than an improved UI, rendering performance, and graphics modernisation?

Also, locking this PR. Please reply in #11843 if you wish

@minetest minetest locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants